Skip to content

imlib2: use xorg.* packages directly instead of xlibsWrapper#194491

Merged
trofi merged 1 commit intoNixOS:masterfrom
arcuru:imlib2
Oct 8, 2022
Merged

imlib2: use xorg.* packages directly instead of xlibsWrapper#194491
trofi merged 1 commit intoNixOS:masterfrom
arcuru:imlib2

Conversation

@arcuru
Copy link
Copy Markdown
Contributor

@arcuru arcuru commented Oct 4, 2022 •
edited
Loading

Description of changes

Replaces xlibsWrapper with direct references to the used packages.

See: #194054

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi trofi mentioned this pull request Oct 4, 2022
Closed
83 tasks
@ofborg ofborg bot requested a review from spwhitt October 4, 2022 21:33
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Oct 4, 2022
trofi
trofi approved these changes Oct 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with diffoscope: the change does not produce material changes.

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 4, 2022
@trofi trofi merged commit e185edf into NixOS:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spwhitt spwhitt Awaiting requested review from spwhitt

1 more reviewer

@trofi trofi trofi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arcuru @trofi @bobby285271