Conversation
|
@primeos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers. |
|
This makes more sense if moved to the The |
|
@joachifm I moved it to the I additionally changed |
|
It would be nice if some of the |
|
@ericsagnes yeah sounds like a good idea. I'm currently trying to add an option to select a vim-package and provide a global vimrc over at #19502 - hope that's roughly what you've expected 😄 Would be interested if that's going in the right direction or not if you have the time 😉 I'll also have to take a closer look at |
Motivation for this change
My main motivation is to provide the
services.vim.defaultEditorwich a user could set in order to make vim (instead of nano) the system wide default text editor via theEDITORenvironment variable (and it'll install vim if that isn't already the case). I don't know if theservices.vim.installoption makes sense since the same effect can be achieved by simply adding vim to the systemPackages.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Note: If both
services.vim.defaultEditorandservices.emacs.defaultEditorare set vim will be the default editor (not tested...) since the priority is lower (mkForce/mkOverride 10vsmkOverride 900). Is that ok or should I also use 900? I just thought mkForce (which apparently uses 10) would fit better. I must also admit that this probably isn't the best solution due to the emacs collision, however the user should avoid that anyway. An alternative would be to introduce a genericdefaultEditoroption.