openjdk*: fix darwin eval failure#194255
Merged
roberth merged 1 commit intoNixOS:staging-nextfrom Oct 4, 2022
Merged
Conversation
only ./pkgs/development/compilers/adoptopenjdk-bin/jdk-linux-base.nix has the gtkSupport option
13 tasks
Member
|
@ofborg build openjdk |
roberth
approved these changes
Oct 4, 2022
Member
roberth
left a comment
There was a problem hiding this comment.
Tested manually on aarch64-darwin.
Member
|
Thanks, and sorry for the inconvenience. |
| then | ||
| # only linux has the gtkSupport option | ||
| if stdenv.isLinux | ||
| then adoptopenjdk.jdk-hotspot.override { gtkSupport = false; } |
Member
There was a problem hiding this comment.
Ideally adoptopenjdk.jdk-hotspot should take the flag on all platforms and complain if gtkSupport is true whne on darwin.
Member
There was a problem hiding this comment.
Or could it take headless ? false?
While adoptopenjdk does not implement a headless optimization on darwin, a missing disk space optimization is harmless to ignore, so that would remove the need for a warning (unlike enabling a non-existing component, which I agree would need a warning).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only ./pkgs/development/compilers/adoptopenjdk-bin/jdk-linux-base.nix has the gtkSupport option
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes