Skip to content

pulseaudio: use xorg.* packages directly instead of xlibsWrapper indi…#194110

Merged
trofi merged 1 commit intoNixOS:stagingfrom
trofi:pulseaudio-without-xlibsWrapper
Oct 8, 2022
Merged

pulseaudio: use xorg.* packages directly instead of xlibsWrapper indi…#194110
trofi merged 1 commit intoNixOS:stagingfrom
trofi:pulseaudio-without-xlibsWrapper

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Oct 2, 2022

…rection

Validated as no change in out and dev outputs with diffoscope on pulseaudio.override { x11Support = true; } expression.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

…rection

Validated as no change in `out` and `dev` outputs with diffoscope on
`pulseaudio.override { x11Support = true; }` expression.
@trofi trofi mentioned this pull request Oct 2, 2022
83 tasks
@ofborg ofborg bot requested a review from lovek323 October 2, 2022 18:24
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 2, 2022
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/call-for-help-to-migrate-packages-from-xlibswrapper/22203/1

@trofi trofi merged commit abeccdf into NixOS:staging Oct 8, 2022
@trofi trofi deleted the pulseaudio-without-xlibsWrapper branch October 8, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants