Skip to content

openssl: cherry-pick upstream fix for for mips64*-linux-*abin32#193843

Closed
ghost wants to merge 2 commits intostagingfrom
unknown repository
Closed

openssl: cherry-pick upstream fix for for mips64*-linux-*abin32#193843
ghost wants to merge 2 commits intostagingfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 1, 2022 •
edited by ghost
Loading

Description of changes

This cherry-picks a fix for mips64*-linux-*abin32 which is merged upstream as:

Things done
  • Built on platform(s)
    • mips64-linux-gnuabin32
  • Tested compilation of a package that depends on this change: curl
  • Tested basic functionality of curl
  • Fits CONTRIBUTING.md.

openssl: fix Configure script for mips64*-linux-*abin32
44fb9f0 
Submitted upstream:

  openssl/openssl#19320

This commit includes `SIXTY_FOUR_BIT` in the `Configure` script's `bn_ops`.  All
the other mips64n32 platforms have this flag, but for some reason it is missing
on linux.  Without it, there is heap corruption.  With it, all is well.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 1, 2022
@ghost ghost changed the title openssl: fix Configure script for mips64*-linux-*abin32 openssl: cherry-pick upstream fix for for mips64*-linux-*abin32 Oct 3, 2022
@ghost ghost mentioned this pull request Oct 3, 2022
Closed
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Oct 3, 2022
@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 3, 2022 •
edited by ghost
Loading

Edit: nevermind, the darwin builder finished first Can anybody explain why ofborg says this?

added the 10.rebuild-darwin-stdenv label

It's been five or six years since I owned any Darwin hardware.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 3, 2022
@ghost ghost marked this pull request as draft October 3, 2022 07:28
@ghost ghost changed the base branch from master to staging October 3, 2022 07:29
@ghost ghost marked this pull request as ready for review October 3, 2022 07:29
@ajs124
Copy link
Copy Markdown
Member

ajs124 commented Oct 27, 2022

This will probably be part of OpenSSL 3.0.7 due next Tuesday (https://www.openwall.com/lists/oss-security/2022/10/25/4), right?

Idk if they'll also do a 1.1.1 release then.

@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 30, 2022

This will probably be part of OpenSSL 3.0.7 due next Tuesday (https://www.openwall.com/lists/oss-security/2022/10/25/4), right?

Unfortunately my time machine is in the shop for repairs, so I am unable to answer your question ;)

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Nov 5, 2022

Yes, current staging has this line fixed in both openssl versions.

@vcunat vcunat closed this Nov 5, 2022
@ghost ghost deleted the pr/mips/fix-n32 branch January 23, 2024 06:49
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajs124 @vcunat