Skip to content

Unpin protobuf3_8 in multiple places#193416

Merged
mweinelt merged 4 commits intoNixOS:masterfrom
mweinelt:protobuffery
Oct 3, 2022
Merged

Unpin protobuf3_8 in multiple places#193416
mweinelt merged 4 commits intoNixOS:masterfrom
mweinelt:protobuffery

Conversation

@mweinelt
Copy link
Copy Markdown
Member

@mweinelt mweinelt commented Sep 28, 2022

Relates to #193370

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 28, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 28, 2022
@mweinelt mweinelt mentioned this pull request Oct 3, 2022
Closed
12 tasks
@mweinelt
python3Packages.tensorboardx: 2.5 -> 2.5.1
a222ca4 
Unpins protobuf; the wanted version is a lower bound, not an upper
one, which is instead given inside setup.py.

https://github.com/lanpa/tensorboardX/blob/v2.5.1/setup.py#L46
@mweinelt
rippled: unpin protobuf
0aee871 
Fails the same three tests as on hydra, so no regression.
@mweinelt
ibus-engines.mozc: unpin protobuf
06ed064 
Also use the git tag, so the package can be better updated.
@mweinelt
python3Packages.coqui-trainer: unpin protobuf
3d1c995
@ofborg ofborg bot requested a review from Mic92 October 3, 2022 13:27
@mweinelt
Copy link
Copy Markdown
Member Author

mweinelt commented Oct 3, 2022 •
edited
Loading

Result of nixpkgs-review pr 193416 run on x86_64-linux 1

4 packages failed to build:
  • python310Packages.elegy
  • python39Packages.elegy
  • rippled
  • rippled-validator-keys-tool
12 packages built:
  • emacsPackages.ac-mozc
  • emacsPackages.mozc
  • emacsPackages.mozc-cand-posframe
  • emacsPackages.mozc-im
  • emacsPackages.mozc-popup
  • emacsPackages.mozc-temp
  • ibus-engines.mozc
  • python310Packages.coqui-trainer
  • python310Packages.tensorboardx
  • python39Packages.coqui-trainer
  • python39Packages.tensorboardx
  • tts

Failures are on target branch.

@mweinelt mweinelt merged commit 4539b69 into NixOS:master Oct 3, 2022
@mweinelt mweinelt deleted the protobuffery branch October 3, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@gebner gebner Awaiting requested review from gebner

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@lebastr lebastr Awaiting requested review from lebastr

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mweinelt