bpftools: add enableDebugger, set to false on Power64 (WIP)#192670
Conversation
`bpftools` is needed by `systemd`, but `bpf_dbg` is not. Currently `bpf_dbg`
fails to build with the error message below. Nothing else in the NixOS ISO
needs `bpf_dbg`, so until I can track down the root cause it's easier to simply
disable that build target.
```
error: builder for '/nix/store/daq740s0f31akfv12p828fv3ri01mv4p-bpftools-5.19.8.drv' failed with exit code 2;
last 10 log lines:
> gcc -Wall -O2 -D__EXPORTED_HEADERS__ -I/build/linux-5.19.8/tools/include/uapi -I/build/linux-5.19.8/tools/include -DDISASM_FOUR_ARGS_SIGNATURE -o bpf_asm bpf_asm.o bpf_exp.yacc.o bpf_exp.lex.o
> gcc -Wall -O2 -D__EXPORTED_HEADERS__ -I/build/linux-5.19.8/tools/include/uapi -I/build/linux-5.19.8/tools/include -DDISASM_FOUR_ARGS_SIGNATURE -c -o bpf_dbg.o /build/linux-5.19.8/tools/bpf/bpf_dbg.c
> In file included from /nix/store/kmpmsx894r939p7wbr6d3g3lfzm41i56-glibc-2.35-163-dev/include/asm/sigcontext.h:14,
> from /nix/store/kmpmsx894r939p7wbr6d3g3lfzm41i56-glibc-2.35-163-dev/include/bits/sigcontext.h:30,
> from /nix/store/kmpmsx894r939p7wbr6d3g3lfzm41i56-glibc-2.35-163-dev/include/signal.h:301,
> from /build/linux-5.19.8/tools/bpf/bpf_dbg.c:51:
> /nix/store/kmpmsx894r939p7wbr6d3g3lfzm41i56-glibc-2.35-163-dev/include/asm/elf.h:160:9: error: unknown type name '__vector128'
> 160 | typedef __vector128 elf_vrreg_t;
> | ^~~~~~~~~~~
> make: *** [Makefile:67: bpf_dbg.o] Error 1
For full logs, run 'nix log /nix/store/daq740s0f31akfv12p828fv3ri01mv4p-bpftools-5.19.8.drv'.
```
This was referenced Sep 23, 2022
14 tasks
Member
|
Is this still needed with #198587? |
Author
It is not! Thank you for letting me know! |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked as draft for now; I will try to find and fix the root cause if possible.
Description of changes
bpftoolsis needed bysystemd, butbpf_dbgis not. Currentlybpf_dbgfails to build with the error message below. Nothing else in the NixOS ISO
needs
bpf_dbg, so until I can track down the root cause it's easier to simplydisable that build target.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes