Skip to content

apk-tools: unsupported rather than broken on darwin#191605

Merged
viraptor merged 1 commit intoNixOS:masterfrom
viraptor:apk-mark-unsupported
Sep 20, 2022
Merged

apk-tools: unsupported rather than broken on darwin#191605
viraptor merged 1 commit intoNixOS:masterfrom
viraptor:apk-mark-unsupported

Conversation

@viraptor
Copy link
Copy Markdown
Contributor

@viraptor viraptor commented Sep 17, 2022 •
edited
Loading

Description of changes

The package was marked broken on darwin, but actually since 2017 (https://gitlab.alpinelinux.org/alpine/apk-tools/-/commit/531fea4c9082d6542c776dcb6d4ca0a3949ecdd0#78bfb265e39dc3513746622558b531382fbd90cd_706_674) the compatibility with non-linux systems has been explicitly removed.
Change the supported platforms to linux only.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 17, 2022
@viraptor viraptor merged commit 96880ad into NixOS:master Sep 20, 2022
@viraptor viraptor deleted the apk-mark-unsupported branch September 20, 2022 23:46
@wegank wegank mentioned this pull request Jan 24, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@viraptor