Skip to content

[haskell-updates]: haskell.packages.ghc924.servant-*: fix with lens 5.2#189437

Merged
cdepillabout merged 3 commits intoNixOS:haskell-updatesfrom
l-epple:servant-lens-5.2
Sep 2, 2022
Merged

[haskell-updates]: haskell.packages.ghc924.servant-*: fix with lens 5.2#189437
cdepillabout merged 3 commits intoNixOS:haskell-updatesfrom
l-epple:servant-lens-5.2

Conversation

@l-epple
Copy link
Copy Markdown
Contributor

@l-epple l-epple commented Sep 2, 2022

Description of changes
Things done

Get servant pkgs that use lens to work with GHC 9.2 and lens 5.2 and fix eval errors in 9.2 set.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 2, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 2, 2022
@cdepillabout
Copy link
Copy Markdown
Member

@ofborg build haskell.packages.ghc924.servant-docs haskell.packages.ghc924.servant-foreign haskell.packages.ghc924.servant-auth haskell.packages.ghc924.servant-auth-docs haskell.packages.ghc924.servant-auth-server haskell.packages.ghc924.servant-auth-swagger haskell.packages.ghc924.servant-multipart haskell.packages.ghc924.swagger2

@l-epple
Copy link
Copy Markdown
Contributor Author

l-epple commented Sep 2, 2022

After this PR nix-build maintainers/scripts/haskell/test-configurations.nix --argstr files configuration-ghc-9.2.x.nix also succeeds again, at least on x86_64-linux.

@cdepillabout
Copy link
Copy Markdown
Member

@l-epple Thanks, ofborg succeeds too. LGTM!

@cdepillabout cdepillabout merged commit c6ce22c into NixOS:haskell-updates Sep 2, 2022
@l-epple l-epple deleted the servant-lens-5.2 branch September 2, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants