Skip to content

make-bootstrap-tools.nix: bootstrapTools: cleanup, comment#188337

Closed
ghost wants to merge 2 commits intomasterfrom
unknown repository
Closed

make-bootstrap-tools.nix: bootstrapTools: cleanup, comment#188337
ghost wants to merge 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 26, 2022

ping @Ericson2314 @vcunat

Description of changes

This PR arose while investigating an issue that @vcunat noticed.

These two commits:

  1. clean up the bootstrapTools expression in make-bootstrap-tools.nix to improve its readability
  2. add a comment explaining what the expression does (unpack the tools, using the tools' own busybox -- not obvious!)

This PR should cause zero rebuilds.

Things done
  • Built on platform(s)
    • x86_64-linux
  • Tested compilation of all packages that depend on this change
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Aug 26, 2022
@ghost ghost marked this pull request as draft August 26, 2022 00:26
@ghost ghost changed the title make-bootstrap-tools.nix: bootstrapTools: cleanup, comment, assert make-bootstrap-tools.nix: bootstrapTools: cleanup, comment Aug 26, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 26, 2022
@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the pr/make-bootstrap-tools/cleanup-and-assert branch October 22, 2023 07:40
Copy link
Copy Markdown
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( we should merge this.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant