libtool: fix shebang-fixing from 2.4.7 version bump#187694
Merged
Conversation
Libtool 2.4.7 changed the shebangs in `libtoolize.in` and `ltmain.sh` from `/bin/sh` (which is a special sandbox exception) to `/usr/bin/env sh` (which is not). My PR (#167071) to bump the libtool version adjusted both of these shebangs, when it should only have adjusted the one in `libtoolize.in`. `ltmain.sh` is not a script to be *executed* at `libtool`-invocation-time. It is a script which is *vendored into a release* at `libtoolize`-invocation-time. Thanks to @trofi for reporting this #167071 (review)
trofi
approved these changes
Aug 21, 2022
Contributor
trofi
left a comment
There was a problem hiding this comment.
Built most of my desktop x86_64-linux system without any problems.
Tested tarball on ski-1.4.0 does not contain /nix/store references any more.
Seems to work. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Libtool 2.4.7 changed the shebangs in
libtoolize.inandltmain.shfrom/bin/sh(which is a special sandbox exception) to/usr/bin/env sh(which is not).My PR (#167071) to bump the libtool version adjusted both of these shebangs, when it should only have adjusted the one in
libtoolize.in.ltmain.shis not a script to be executed atlibtool-invocation-time. It is a script which is vendored into a release atlibtoolize-invocation-time.Thanks to @trofi for reporting this.
Things done
./result/bin/)