Skip to content

python310Packages.loguru: fix failing tests#186555

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
tjni:fix-loguru
Aug 15, 2022
Merged

python310Packages.loguru: fix failing tests#186555
mweinelt merged 1 commit intoNixOS:staging-nextfrom
tjni:fix-loguru

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 14, 2022

Description of changes

Pulls in a patch from upstream that fixes test failing on Python 3.10.6
and greater.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni
python310Packages.loguru: fix failing tests
b518a7d 
Pulls in a patch from upstream that fixes test failing on Python 3.10.6
and greater.
@tjni tjni requested review from FRidh and jonringer as code owners August 14, 2022 02:04
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 14, 2022
@ofborg ofborg bot requested review from jbaum98 and rmcgibbo August 14, 2022 02:13
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 14, 2022
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 14, 2022

Related to #185426.

@mweinelt mweinelt added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 14, 2022
@mweinelt mweinelt merged commit 775bb14 into NixOS:staging-next Aug 15, 2022
@tjni tjni deleted the fix-loguru branch August 15, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@jbaum98 jbaum98 Awaiting requested review from jbaum98

1 more reviewer

@rmcgibbo rmcgibbo rmcgibbo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjni @rmcgibbo @mweinelt