btrfs-progs: allow to build without python bindings#186527
Merged
Conversation
Member
|
@ofborg eval |
Member
|
Hm, it sounds like the second commit does more than the commit message claims and then the third commit undos the part actually in the commit message? Maybe squash then? |
Author
|
Yeah sorry the second commit was made in order to reduce the rebuilds to zero (so ofborg would remove the "red oval of shame" from my PR), and then the third commit reverted some parts of the second commit that turned out not to be necessary. In any event: squashed. |
Author
|
Merge conflict resolved. |
ck3d
requested changes
Sep 1, 2022
Contributor
ck3d
left a comment
There was a problem hiding this comment.
I seems you merged master into your branch. Could you please make a rebase on master instead.
Python cross-compilation is quite difficult, and doesn't work in several situations, such as: #186525 Let's give people the option of cross-compiling `btrfs-progs` to hostPlatforms for which we cannot cross-compile python. Unfortunately btrfs-progs insists on a special configure flag `--disable-python`; simply being unable to find python isn't enough.
Member
|
Result of |
rapenne-s
approved these changes
Sep 1, 2022
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Python cross-compilation is quite difficult, and doesn't work in several situations, such as:
#186525
Let's give people the option of cross-compiling
btrfs-progsto hostPlatforms for which we cannot cross-compile python. Unfortunately btrfs-progs insists on a special configure flag--disable-python; simply being unable to find python isn't enough.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)