Skip to content

zlib: add fixed patch for CVE-2022-37434#185693

Merged
vcunat merged 2 commits intoNixOS:stagingfrom
winterqt:zlib-CVE-2022-37434
Aug 9, 2022
Merged

zlib: add fixed patch for CVE-2022-37434#185693
vcunat merged 2 commits intoNixOS:stagingfrom
winterqt:zlib-CVE-2022-37434

Conversation

@winterqt
Copy link
Copy Markdown
Member

@winterqt winterqt commented Aug 8, 2022 •
edited by pennae
Loading

Description of changes

This adds a fixed patch for CVE-2022-37434.

See the discussion in #185578 and curl/curl#9271 for more information.

To whoever merges: please rebase and merge; I don't like the branch name. Thanks.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@winterqt winterqt added 1.severity: security Issues which raise a security issue, or PRs that fix one backport staging-22.05 labels Aug 8, 2022
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 8, 2022
@pennae
Copy link
Copy Markdown
Contributor

pennae commented Aug 8, 2022 •
edited
Loading

built curl.tests on x86_64-linux, even the nginx test (which failed to build yesterday with the broken zlib patch)

@vcunat vcunat merged commit 42ebd6e into NixOS:staging Aug 9, 2022
@github-actions github-actions bot mentioned this pull request Aug 9, 2022
Merged
1 task
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 9, 2022

Successfully created backport PR #185754 for staging-22.05.

@Faaux Faaux mentioned this pull request Sep 14, 2022
Closed
@Neustradamus
Copy link
Copy Markdown

Neustradamus commented Oct 14, 2022

@madler has done the new build, the 1.2.13 has been released with the CVE-2022-37434 fix.

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Oct 17, 2022

@madler has done the new build, the 1.2.13 has been released with the CVE-2022-37434 fix.

Updated in #196167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mindavi Mindavi Mindavi approved these changes

@pennae pennae pennae approved these changes

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@winterqt @pennae @Neustradamus @mweinelt @Mindavi @vcunat