stdenv: Pass -lN to GNU Make based on NIX_LOAD_LIMIT#184886
Closed
centromere wants to merge 1 commit intoNixOS:stagingfrom
Closed
stdenv: Pass -lN to GNU Make based on NIX_LOAD_LIMIT#184886centromere wants to merge 1 commit intoNixOS:stagingfrom
centromere wants to merge 1 commit intoNixOS:stagingfrom
Conversation
13 tasks
13 tasks
Member
Author
|
Closing because of #192447. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
On busy machines where Nix co-exists with other workloads, parallelism not work as intended. For example, consider a 64 core machine whose load average is 24 and where Nix is limited to 8 cores. By default,
-j8 -l8will be passed to GNU Make. Since the load average exceeds 8, no parallelism will take place despite the fact that 8 cores are available. In this case,load-limitshould be set to0to prevent the-lNflag from being passed to GNU Make.See also: #174473 NixOS/nix#6855
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes