ghdl: use gnat11 to unbreak build#184352
Merged
SuperSandro2000 merged 3 commits intomasterfrom Aug 3, 2022
unknown repository
Merged
ghdl: use gnat11 to unbreak build#184352SuperSandro2000 merged 3 commits intomasterfrom unknown repository
SuperSandro2000 merged 3 commits intomasterfrom
unknown repository
Conversation
ghdl-1.0.0 does not build with gnat12. The fixes appear to be upstream, but are spread across several patches. I tried cherry-picking the following: https://github.com/ghdl/ghdl/pull/2057/commits/4c3825daf54f81433e5de46cc25fdfac7189ffab.patch https://github.com/ghdl/ghdl/pull/2057/commits/8c5689b93e68ac34cdf7dd089a3990ae22f0049c.patch https://github.com/ghdl/ghdl/commit/f8b87697e8b893b6293ebbfc34670c32bfb49397.patch https://github.com/ghdl/ghdl/commit/54a18dda071449e80982da9e31be4685da30f0ed.patch ... but eventually ran up against a failure in a file which had been deleted from upstream prior to their "fix gnat12" push, so there is no simple cherry-pick. Let's fall back to gnat11 until we can update to a newer ghdl.
Contributor
|
Is there a reason we can't update to a newer ghdl right now? I see version 2.0.0 has been released a few months ago. |
Lucus16
approved these changes
Aug 1, 2022
Contributor
Lucus16
left a comment
There was a problem hiding this comment.
I tried it for a bit, but updating to ghdl 2.0.0 does not seem trivial so this seems like a fine solution.
Contributor
|
Or actually, updating to ghdl 2.0.0 is trivial but still needs gnat11. |
Author
Yeah that was my conclusion as well. Also I encountered some breakage in packages downstream of ghdl after the upgrade ( |
Author
|
If you do bump the version please consider hanging on to |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Our ghdl is currently broken because ghdl-1.0.0 does not build with gnat12. The fixes appear to be upstream, but are spread across several patches. I tried cherry-picking the following:
... but eventually ran up against a failure in a file which had been deleted from upstream prior to their "fix gnat12" push, so there is no simple cherry-pick.
Let's fall back to gnat11 until we can update to a newer ghdl.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)