Skip to content

gnupg: remove ? null from inputs, remove with lib #183753

Merged
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
SuperSandro2000:systemd-gnupg-null
Jul 30, 2022
Merged

gnupg: remove ? null from inputs, remove with lib #183753
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
SuperSandro2000:systemd-gnupg-null

Conversation

@SuperSandro2000
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 commented Jul 29, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from WilliButz, fpletz, globin, mmahut and vrthra July 29, 2022 18:16
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 29, 2022
@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging July 29, 2022 18:52
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review July 29, 2022 18:52
@bobby285271 bobby285271 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 30, 2022
@SuperSandro2000 SuperSandro2000 merged commit 056ddc3 into NixOS:staging Jul 30, 2022
@SuperSandro2000 SuperSandro2000 deleted the systemd-gnupg-null branch July 30, 2022 16:14
@aidalgol aidalgol mentioned this pull request Aug 24, 2022
Closed
@lopsided98
Copy link
Copy Markdown
Contributor

lopsided98 commented Aug 31, 2022

What was the reason for this change?

I need to be able to disable pcsclite to avoid a dependency on spidermonkey (through polkit) on my ARM systems. enableMinimal is not usable because it basically breaks the package by removing gpg-agent.

I think we should either fix enableMinimal so it produces a package useful for things besides systemd, or add back some other way of trimming the dependencies.

@SuperSandro2000
Copy link
Copy Markdown
Member Author

SuperSandro2000 commented Aug 31, 2022

What was the reason for this change?

Reduce complexity and remove the error prone usage of package ? null in inputs.

I think we should either fix enableMinimal so it produces a package useful for things besides systemd, or add back some other way of trimming the dependencies.

We probably only have this option because of dependency cycle(s). Another option would be to add an option like withPcsc.

@ghost ghost mentioned this pull request Sep 5, 2022
Merged
11 tasks
@lopsided98 lopsided98 mentioned this pull request Sep 17, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpletz fpletz fpletz approved these changes

@WilliButz WilliButz Awaiting requested review from WilliButz

@globin globin Awaiting requested review from globin

@mmahut mmahut Awaiting requested review from mmahut

@vrthra vrthra Awaiting requested review from vrthra

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SuperSandro2000 @lopsided98 @fpletz @bobby285271