Skip to content

pkgs/top-level/stage.nix: rename mkMuslParsedPlatform, improve comment#183459

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

pkgs/top-level/stage.nix: rename mkMuslParsedPlatform, improve comment#183459
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 28, 2022

Description of changes

The existing name and descriptive comment for mkMuslParsedPlatform are not so great, and has led to people misunderstanding what it does.

Let's help ensure that additional case-branches are added correctly in the future by explaining what this function is supposed to do.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from Ericson2314, matthewbauer and nbp as code owners July 28, 2022 19:31
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 28, 2022
@ghost ghost marked this pull request as draft September 26, 2022 03:49
@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 26, 2022

Resolved merge conflict.

@ghost ghost marked this pull request as ready for review September 26, 2022 03:50
@ghost ghost marked this pull request as draft October 3, 2022 07:49
@ghost ghost marked this pull request as ready for review October 3, 2022 07:50
@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 3, 2022

Resolved merge conflict.

pkgs/top-level/stage.nix: rename mkMuslParsedPlatform, improve comment
2f4be6d 
The existing name and descriptive comment for mkMuslParsedPlatform are
not so great, and has led to people misunderstanding what it does:

  #182807 (comment)

Let's help ensure that additional case-branches are added correctly in
the future by explaining what this function is supposed to do.
@ghost ghost closed this Apr 24, 2023
@ghost ghost deleted the pr/renameMkMuslParsedPlatform branch April 24, 2023 02:22
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbp nbp Awaiting requested review from nbp

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants