haskellPackages.aeson-typescript: fix the testsuite and unbreak#182389
haskellPackages.aeson-typescript: fix the testsuite and unbreak#182389maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
There was a problem hiding this comment.
One nitpick: I think this should be testToolDepends instead of buildTools.
If you look through pkgs/development/haskell-modules/generic-builder.nix you can see that testToolDepends is used almost the same as buildTools, except that it gets ignored if you set dontCheck (which I believe is what we want in this case).
Other than that, this LGTM, thanks!
There was a problem hiding this comment.
oh, brilliant, i was looking for that but missed it. Will change.
|
Thanks for updating this. Could you change the title on the latest commit to match the format as described in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md? Or just squashing these two commits together might be the easiest. After you do that, I think this can be merged. |
|
Huh, does nixpkgs have the github squash and merge feature turned off? Usually you can click the little arrow next to the merge button to select that. |
|
@lf- I am not sure how strong a reason that is, but If we do that, we lose the merge commit. Which is against nixpkgs convention. |
|
Oh, wild. I didn't know it did that. Rebased. |
Description of changes
I fixed the testsuite of aeson-typescript, which was failing due to a lack of working tsc. I have manually marked it unbroken (not sure how to use the tools to do it for me; I tried
./maintainers/scripts/haskell/mark-broken.shand it failed due to #175875).Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes