Skip to content

tbb: Fix build for aarch64-darwin#182367

Merged
veprbl merged 1 commit intoNixOS:masterfrom
tanshihaj:master-tbb
Jul 24, 2022
Merged

tbb: Fix build for aarch64-darwin#182367
veprbl merged 1 commit intoNixOS:masterfrom
tanshihaj:master-tbb

Conversation

@tanshihaj
Copy link
Copy Markdown
Contributor

Description of changes

Fix build for aarch64-darwin of package tbb by applying patch from upstream.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label Jul 21, 2022
@ofborg ofborg Bot requested a review from thoughtpolice July 21, 2022 19:07
@ofborg ofborg Bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jul 21, 2022
Comment thread pkgs/development/libraries/tbb/default.nix Outdated
@risicle
Copy link
Copy Markdown
Contributor

risicle commented Jul 21, 2022

Builds for me, macos 12.4 aarch64.

nixpkgs-review happy, macos 10.15

@veprbl veprbl merged commit 46cf1b9 into NixOS:master Jul 24, 2022
@tanshihaj tanshihaj deleted the master-tbb branch August 6, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants