gpsd: unbreak the build for guiSupport=false#182173
Merged
Conversation
The `rm $out/bin/xgps*` command fails because that file is not there in the first place. Let's change it to `rm -f $out/bin/xgps*` so we can build with `guiSupport=false`.
Author
|
Ping @bjornfor @rasendubi |
Member
|
Do I understand that the file is never there? (assuming |
Author
I believe that is correct.
An abundance of caution. But you're right, leaving dead code there is worse. I've removed it in the latest commit. |
Member
|
It fails the same on 22.05. |
1 task
Contributor
|
Successfully created backport PR #183323 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The
rm $out/bin/xgps*command fails because that file is not there in the first place. Let's change it torm -f $out/bin/xgps*so we can build withguiSupport=false.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)