libtiff: upgrade to 4.4.0 for aarch64-darwin and adjust patch#181446
Closed
tanshihaj wants to merge 1 commit intoNixOS:masterfrom
Closed
libtiff: upgrade to 4.4.0 for aarch64-darwin and adjust patch#181446tanshihaj wants to merge 1 commit intoNixOS:masterfrom
tanshihaj wants to merge 1 commit intoNixOS:masterfrom
Conversation
Member
|
At this point, why can't we just drop |
1892ba3 to
4fc038d
Compare
Contributor
Author
|
That's strange - |
13 tasks
Contributor
Author
|
Continue in #182254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
For some reason, libraries that depend on libtiff on
aarch64-darwinplatform won't build since they cannot find some functions added in 4.4.0 (and libtiff version 4.2.0 which is currently used in nixpkgs foraarch64-darwinplatform doesn't have them). Issue can be reproduced with FreeImage that depends on libtiff.Here I'm upgrading libtiff upto 4.4.0 and changing path so it will apply with new version of libtiff.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes