Skip to content

libtiff: upgrade to 4.4.0 for aarch64-darwin and adjust patch#181446

Closed
tanshihaj wants to merge 1 commit intoNixOS:masterfrom
tanshihaj:libtiff-aarch64-darwin
Closed

libtiff: upgrade to 4.4.0 for aarch64-darwin and adjust patch#181446
tanshihaj wants to merge 1 commit intoNixOS:masterfrom
tanshihaj:libtiff-aarch64-darwin

Conversation

@tanshihaj
Copy link
Copy Markdown
Contributor

Description of changes

For some reason, libraries that depend on libtiff on aarch64-darwin platform won't build since they cannot find some functions added in 4.4.0 (and libtiff version 4.2.0 which is currently used in nixpkgs for aarch64-darwin platform doesn't have them). Issue can be reproduced with FreeImage that depends on libtiff.

Here I'm upgrading libtiff upto 4.4.0 and changing path so it will apply with new version of libtiff.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 14, 2022
@ajs124
Copy link
Copy Markdown
Member

ajs124 commented Jul 14, 2022

At this point, why can't we just drop pkgs/development/libraries/libtiff/aarch64-darwin.nix and use the regular libtiff on aarch64-darwin?

@tanshihaj tanshihaj force-pushed the libtiff-aarch64-darwin branch from 1892ba3 to 4fc038d Compare July 14, 2022 18:56
@tanshihaj
Copy link
Copy Markdown
Contributor Author

That's strange - default.nix worked out of the box on aarch64-darwin. Why aarch64-darwin.nix needed in the first place?

@tanshihaj tanshihaj closed this Jul 20, 2022
@tanshihaj tanshihaj deleted the libtiff-aarch64-darwin branch July 20, 2022 19:52
@tanshihaj
Copy link
Copy Markdown
Contributor Author

Continue in #182254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants