Skip to content

ntl: explicitly set 'configurePlatforms = [ ];'#181061

Merged
Mindavi merged 1 commit intoNixOS:masterfrom
trofi:configurePlatforms-for-ntl
Jul 12, 2022
Merged

ntl: explicitly set 'configurePlatforms = [ ];'#181061
Mindavi merged 1 commit intoNixOS:masterfrom
trofi:configurePlatforms-for-ntl

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Jul 11, 2022 •
edited
Loading

Without the change build with config.configurePlatformsByDefault = true
fails as:

$ nix build -f. ntl --arg config '{ configurePlatformsByDefault = true; }' -L
...
Error: unrecognized option: --build=x86_64-unknown-linux-gnu
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
ntl: explicitly set 'configurePlatforms = [ ];'
6628132 
Without the change build with config.configurePlatformsByDefault = true
fails as:

    $ nix build -f. ntl --arg config '{ configurePlatformsByDefault = true; }' -L
    ...
    Error: unrecognized option: --build=x86_64-unknown-linux-gnu
@trofi trofi mentioned this pull request Jul 11, 2022
Draft
10 tasks
@ofborg ofborg bot requested review from 7c6f434c, collares, omasanori and timokau July 11, 2022 07:54
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 11, 2022
collares
collares approved these changes Jul 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@collares collares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mindavi Mindavi merged commit 019931c into NixOS:master Jul 12, 2022
@trofi trofi deleted the configurePlatforms-for-ntl branch July 12, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@collares collares collares approved these changes

@Mindavi Mindavi Mindavi approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@timokau timokau Awaiting requested review from timokau

@omasanori omasanori Awaiting requested review from omasanori

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trofi @collares @Mindavi