Skip to content

stdenv: start deprecating non-list mesonFlags#180302

Merged
Artturin merged 2 commits intoNixOS:stagingfrom
Artturin:depmesonstring
Jul 6, 2022
Merged

stdenv: start deprecating non-list mesonFlags#180302
Artturin merged 2 commits intoNixOS:stagingfrom
Artturin:depmesonstring

Conversation

@Artturin
Copy link
Copy Markdown
Member

@Artturin Artturin commented Jul 6, 2022 •
edited
Loading

the motivation for this is to simplify stdenv and ease the job of
reviewers due to them needing to tell contributors about the defacto
rule that mesonFlags should be a list of strings

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jul 6, 2022
@Artturin Artturin changed the title stdenv: start deprecating non-list cmakeFlags stdenv: start deprecating non-list mesonFlags Jul 6, 2022
@Artturin Artturin mentioned this pull request Jul 6, 2022
Merged
13 tasks
@Artturin Artturin marked this pull request as ready for review July 6, 2022 03:27
@r-burns
Copy link
Copy Markdown
Contributor

r-burns commented Jul 6, 2022

Looks like there is a string-typed mesonFlags in speech-denoiser causing the ofborg eval error

jtojnar
jtojnar reviewed Jul 6, 2022
View reviewed changes
jtojnar
jtojnar reviewed Jul 6, 2022
View reviewed changes
Mindavi
Mindavi reviewed Jul 6, 2022
View reviewed changes
@Artturin
stdenv: start deprecating non-list mesonFlags
ca2ca8b 
the motivation for this is to simplify stdenv and ease the job of
reviewers due to them needing to tell contributors about the defacto
rule that mesonFlags should be a list of strings
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Jul 6, 2022
@ofborg ofborg bot requested a review from magnetophon July 6, 2022 13:57
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 6, 2022
magnetophon
magnetophon approved these changes Jul 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

speech-denoiser LGTM, thanks!

@Artturin Artturin merged commit 958f924 into NixOS:staging Jul 6, 2022
@Artturin Artturin deleted the depmesonstring branch July 6, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mindavi Mindavi Mindavi left review comments

@jtojnar jtojnar jtojnar approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

+1 more reviewer

@magnetophon magnetophon magnetophon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Artturin @r-burns @jtojnar @magnetophon @Mindavi