Skip to content

openjdk/meta.nix: add powerpc64le-linux to platforms#180032

Merged
SuperSandro2000 merged 1 commit intomasterfrom
unknown repository
Dec 9, 2022
Merged

openjdk/meta.nix: add powerpc64le-linux to platforms#180032
SuperSandro2000 merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 3, 2022

Description of changes

This commit adds "powerpc64le-linux" to the platforms list in openjdk/meta.nix, so users do not need to add NIX_ALLOW_UNSUPPORTED=1 when building jdk11 (and things which depend on it, like chromium) on powerpc64le-linux.

Things done
  • Built on platform(s)
    • powerpc64le-linux
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 3, 2022
@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 27, 2022

Ping @edwtjo and @asbachb (openjdk maintainers).

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 4, 2022

Ping.

@asbachb
Copy link
Copy Markdown
Contributor

asbachb commented Sep 4, 2022

@amjoseph-nixpkgs Actually I'm unsure how to validate. Can you paste compiled binary output?

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 4, 2022

@amjoseph-nixpkgs Actually I'm unsure how to validate.

I can give you a login on one of my Talos2 machines if you like. I didn't see an ssh or gpg key for you in maintainers/maintainer-list.nix.

Can you paste compiled binary output?

Sure, let me rebase this to latest master and do a build at exactly the commit-to-be-merged. I'll paste the build log here when it's done. Do you want the .nar as well?

@ghost ghost marked this pull request as draft September 4, 2022 20:57
@ghost ghost marked this pull request as ready for review September 4, 2022 20:57
@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 4, 2022

f24148a is the original PR, rebased to latest origin/master. I'm rebuilding from there.

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 4, 2022

$ nix build -f . -L jdk11_headless

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 4, 2022

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 4, 2022

You should be able to produce the exact same drv even without powerpc64le-linux hardware. I ran the following commands on both my Talos2 and an x86_64 machine and the drv-hash came out the same (note you must override the system attrtibute!):

$ git rev-parse HEAD
f24148ab1fabeb1a12e2c28d995fac16ba321bef

$ nix-instantiate . -A jdk11_headless --option system powerpc64le-linux
/nix/store/47fyvb1yx2pf19c9b9s8q91fzy6r8i99-openjdk-headless-11.0.15+10.drv

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 5, 2022
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 9, 2022

Ping.

@SuperSandro2000
Copy link
Copy Markdown
Member

We don't have any powerpc hardware on hydra so this couldn't trigger any builds, so we can just merge it.

@SuperSandro2000 SuperSandro2000 merged commit 0d6316e into NixOS:master Dec 9, 2022
@ghost ghost deleted the pr/powerpc64le/openjdk-platforms branch December 10, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants