Skip to content

Replace use of testVersion alias#179226

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
bdd:use_testers_testversion
Jun 27, 2022
Merged

Replace use of testVersion alias#179226
Mic92 merged 1 commit intoNixOS:masterfrom
bdd:use_testers_testversion

Conversation

@bdd
Copy link
Copy Markdown
Contributor

@bdd bdd commented Jun 26, 2022

  • lndconnect: Drop unused input testVersion
  • other packages: Import testers and use testers.testVersion
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bdd
Replace use of testVersion alias
a9f9124 
- lndconnect: Drop unused input `testVersion`
- other packages: Import `testers` and use `testers.testVersion`
@bdd bdd requested review from RaghavSood and mmahut as code owners June 26, 2022 17:45
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 26, 2022
@bdd bdd mentioned this pull request Jun 26, 2022
Merged
13 tasks
@Mic92 Mic92 merged commit 725cee0 into NixOS:master Jun 27, 2022
@bdd bdd deleted the use_testers_testversion branch December 4, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdd @Mic92