fetchgit: change allowedRequisites default from null to []#178831
Conversation
If this commit broke eval for your package: 1. I apologize! 2. Please try adding `allowedRequisites=null` to your fetcher. 3. If (2) does not work, do not hesitate to revert this commit and ping @a-m-joseph to let me know I need to investigate.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not ready to be merged yet!
Writing the one-line commit for this PR was the easy part. The hard part is making sure I don't break nixpkgs eval for a ton of people. I will undraftify this when I have made sure, and explain the process (which will be mostly
this) once I have done so.
This draft PR is mainly a way of putting this task on my nixpkgs to-do list. However comments are welcome, including comments that say "this is a dumb idea".
Description of changes
As originally suggested in #177326, and as further encouraged here, this commit changes the default
allowedRequisitesoffetchgitfromnull(any requisites allowed) to[](no requisites allowed unless overridden).Commit Message
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes