Skip to content

python3Packages.uharfbuzz: only add ApplicationServices if stdenv.isDarwin#178795

Merged
lovesegfault merged 1 commit intoNixOS:staging-nextfrom
lovesegfault:darwin-fix-uharfbuzz-redux
Jun 24, 2022
Merged

python3Packages.uharfbuzz: only add ApplicationServices if stdenv.isDarwin#178795
lovesegfault merged 1 commit intoNixOS:staging-nextfrom
lovesegfault:darwin-fix-uharfbuzz-redux

Conversation

@lovesegfault
Copy link
Copy Markdown
Member

@lovesegfault lovesegfault commented Jun 23, 2022

Description of changes

Hopefully fixes this and its reverse deps.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 23, 2022
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 23, 2022
@ofborg ofborg bot requested a review from WolfangAukang June 23, 2022 20:57
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 23, 2022
@lovesegfault lovesegfault merged commit 91526a4 into NixOS:staging-next Jun 24, 2022
@lovesegfault lovesegfault deleted the darwin-fix-uharfbuzz-redux branch June 24, 2022 14:48
@trofi trofi mentioned this pull request Jun 25, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@WolfangAukang WolfangAukang Awaiting requested review from WolfangAukang

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lovesegfault