treewide: set sourceProvenance for packages containing downloaded jars#176278
Merged
risicle merged 3 commits intoNixOS:masterfrom Jun 5, 2022
Merged
treewide: set sourceProvenance for packages containing downloaded jars#176278risicle merged 3 commits intoNixOS:masterfrom
sourceProvenance for packages containing downloaded jars#176278risicle merged 3 commits intoNixOS:masterfrom
Conversation
these are the easily identifiable cases and will not be comprehensive
these presumably contain binary jars in their deps
SuperSandro2000
approved these changes
Jun 4, 2022
Member
SuperSandro2000
left a comment
There was a problem hiding this comment.
Didn't double check if 100% of the packages are really like this but seems logical to me and the code seems to be alright.
| , sha512 | ||
| , type ? "jar" | ||
| , suffix ? "" | ||
| , sourceProvenance ? (if type == "jar" then [ lib.sourceTypes.binaryBytecode ] else []) |
Member
There was a problem hiding this comment.
I didn't double check if this is right.
| meta = with lib; { | ||
| homepage = "https://github.com/tobiasmelcher/EclipseAceJump"; | ||
| description = "Provides fast jumps to text based on initial letter"; | ||
| sourceProvenance = with sourceTypes; [ binaryBytecode ]; |
Member
There was a problem hiding this comment.
I would suggest to move this to buildEclipsePlugin since probably all or most plugins are like this.
Contributor
Author
There was a problem hiding this comment.
I think some people might find that to be surprising behaviour.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a broad and coarse sweep for packages I could easily identify as containing downloaded jars in their outputs. It may well need further refinement from package maintainers. Some of these packages also contain binary native code, but I have not marked that in this PR - though I've made a note of these packages for the native-code-sweep.
Packages which build the main package but use binary dependencies have been marked as both
fromSourceandbinaryBytecodeto differentiate them from packages which simply download the whole thing. The practical difference here is that the former packages would be patchable if necessary, whereas the latter wouldn't.Gradle-based builds are included as a separate commit as I wasn't quite so 100% sure where they were all gathering their
depsfrom. It's oddly opaque.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes