Skip to content

openldap: Fix parallel build error#175994

Closed
dsg22 wants to merge 1 commit intoNixOS:stagingfrom
dsg22:feature-openldap-fix-parallel-build
Closed

openldap: Fix parallel build error#175994
dsg22 wants to merge 1 commit intoNixOS:stagingfrom
dsg22:feature-openldap-fix-parallel-build

Conversation

@dsg22
Copy link
Copy Markdown
Contributor

@dsg22 dsg22 commented Jun 2, 2022

Fixes #175626

Description of changes

openldap build failed due to missing object files. Apply the upstream patch to fix dependencies in Makefile.

Fixes #175626

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ajs124, dasJ and mweinelt June 2, 2022 20:18
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 2, 2022
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jun 2, 2022

This is too big to go into master. Please rebase onto staging, see CONTRIBUTING.md on how to rebase properly if in doubt.

@dasJ dasJ mentioned this pull request Jun 4, 2022
Merged
13 tasks
@dsg22
openldap: Fix parallel build error
7580c66 
openldap build failed due to missing object files. Apply the upstream
patch to fix dependencies in Makefile.

Fixes NixOS#175626
@dsg22 dsg22 force-pushed the feature-openldap-fix-parallel-build branch from 73b1ddf to 7580c66 Compare June 4, 2022 23:26
@github-actions github-actions bot added 6.topic: kernel The Linux kernel 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment labels Jun 4, 2022
@dsg22 dsg22 changed the base branch from master to staging June 4, 2022 23:26
@github-actions github-actions bot removed 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: stdenv Standard environment 6.topic: kernel The Linux kernel 6.topic: python Python is a high-level, general-purpose programming language. labels Jun 4, 2022
@dsg22
Copy link
Copy Markdown
Contributor Author

dsg22 commented Jun 4, 2022

This is too big to go into master. Please rebase onto staging, see CONTRIBUTING.md on how to rebase properly if in doubt.

Sure, no problem. Just did that and changed the base for this PR to staging branch.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. labels Jun 4, 2022
@ofborg ofborg bot added 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 4, 2022
@dasJ
Copy link
Copy Markdown
Member

dasJ commented Jun 6, 2022

Closed in #176290 which fixes issues with syncrepl as well

@dasJ dasJ closed this Jun 6, 2022
@dsg22 dsg22 deleted the feature-openldap-fix-parallel-build branch June 6, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@ajs124 ajs124 Awaiting requested review from ajs124

@dasJ dasJ Awaiting requested review from dasJ

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

openldap-2.6.2 fails to build with ld input file not found

3 participants

@dsg22 @mweinelt @dasJ