Skip to content

libspnav: fix cross-compilation#175668

Merged
Mindavi merged 1 commit intomasterfrom
unknown repository
Jun 2, 2022
Merged

libspnav: fix cross-compilation#175668
Mindavi merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 31, 2022

Description of changes

Prior to this commit, pkgsCross.foo.libspnav would fail with something like:

/nix/store/...-bash-5.1-p16/bin/bash: line 1: ar: command not found

Let's fix that by passing AR= in makeFlags.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Prior to this commit, pkgsCross.foo.libspnav would fail with something
like:

```
/nix/store/...-bash-5.1-p16/bin/bash: line 1: ar: command not found
```

Let's fix that by passing `AR=` in `makeFlags`.
@ofborg ofborg bot requested a review from Sohalt June 1, 2022 00:20
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 1, 2022
@siraben
Copy link
Copy Markdown
Member

siraben commented Jun 1, 2022

Result of nixpkgs-review pr 175668 run on aarch64-darwin 1

2 packages built:
  • libspnav
  • spacenav-cube-example

@Mindavi Mindavi added 6.topic: cross-compilation Building packages on a different platform than they will be used on backport release-22.05 labels Jun 2, 2022
@Mindavi Mindavi merged commit 7d26f29 into NixOS:master Jun 2, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2022

Successfully created backport PR #175978 for release-22.05.

@ghost ghost deleted the pr/libspnav/crosscompile branch June 5, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants