Skip to content

purescript: mark meta.sourceProvenance#175501

Merged
cdepillabout merged 2 commits intomasterfrom
unknown repository
Jul 18, 2022
Merged

purescript: mark meta.sourceProvenance#175501
cdepillabout merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 30, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ghost ghost changed the title koreader: mark meta.sourceProvenance purescript: mark meta.sourceProvenance May 30, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 30, 2022
@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 11, 2022

Ping...

@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Jul 18, 2022

This LGTM, thanks.

@amjoseph-nixpkgs You generally need to cc the maintainers of the package, otherwise no one gets notified of this PR. I only saw it because I just happened to search for purescript for unrelated reasons.

@cdepillabout cdepillabout merged commit 99b97a7 into NixOS:master Jul 18, 2022
@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 18, 2022

You generally need to cc the maintainers of the package, otherwise no one gets notified of this PR.

Wow, thanks for letting me know. I assumed the whole reason we put github IDs in maintainers.nix was in order to make that happen automatically.=

@ghost ghost deleted the pr/sourceProvenance/purescript branch July 18, 2022 20:10
@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Jul 19, 2022

I assumed the whole reason we put github IDs in maintainers.nix was in order to make that happen automatically.

Yeah, normally it does happen automatically. I have no idea why it didn't happen here!

@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cdepillabout