Skip to content

koreader: 2022.03.01 -> 2022.05.01#175099

Merged
bobby285271 merged 1 commit intomasterfrom
unknown repository
May 31, 2022
Merged

koreader: 2022.03.01 -> 2022.05.01#175099
bobby285271 merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 28, 2022 •
edited by ghost
Loading

Description of changes

Gee it would be nice if this built from source...

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from contrun May 28, 2022 10:19
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 28, 2022
contrun
contrun approved these changes May 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@contrun contrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks. I agree builting from source would be great.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 31, 2022 •
edited by ghost
Loading

I agree builting from source would be great.

Be careful what you wish for: 😉 koreader/koreader-base#1486

@bobby285271 bobby285271 merged commit 6d2d2e3 into NixOS:master May 31, 2022
@ghost ghost deleted the pr/bump/koreader branch May 31, 2022 19:44
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@contrun @bobby285271