Merged
Conversation
This is mostly done by disabling the tests or the entire package on Darwin
Contributor
|
Result of 6 packages built:
|
Contributor
|
Result of 1 package marked as broken and skipped:
18 packages failed to build:
12 packages built:
|
zakame
reviewed
May 27, 2022
| homepage = "https://github.com/mongodb-labs/mongo-perl-bson-xs"; | ||
| description = "XS implementation of MongoDB's BSON serialization (EOL)"; | ||
| license = lib.licenses.asl20; | ||
| platforms = lib.platforms.linux; # configure phase fails with "ld: unknown option: -mmacosx-version-min=10.12" |
Member
There was a problem hiding this comment.
Would setting export LD=$CC environment work for this? I reckon that's how we do on linker failures like this one on Darwin.
Mindavi
approved these changes
May 27, 2022
1 task
Contributor
|
Successfully created backport PR #174961 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly done by disabling the tests or the entire package on
Darwin
Description of changes
ZHF: #172160 cc @NixOS/nixos-release-managers
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes