Skip to content

gcc: if langAda then propagate brokenness from gnatboot#173813

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

gcc: if langAda then propagate brokenness from gnatboot#173813
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 20, 2022

Description of changes

This commit causes gcc${version}.meta.broken to become true if langAda and gnatboot.meta.broken. This means that marking any part of the gnatboot chain broken will propagate the broken attribute through the chain of gnat6,gnat9,gnat10,gnat11,gnat12 builds.

This commit does not mark any packages as broken. It simply automates the propagation of brokenness so downstream packages can respond intelligently (e.g. #173808)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from matthewbauer as a code owner May 20, 2022 22:18
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 20, 2022
@felixsinger felixsinger self-requested a review May 21, 2022 04:09
@sternenseemann
Copy link
Copy Markdown
Member

I don't think we really need this; ideally GNAT never regresses again. A fix for the GNAT 6 problem is in staging, the thing we should do is search for a replacement for gnatboot: Gentoo doesn't use it anymore and has even deleted it from its mirrors. I have no clue what debian does (maybe the previous version of the package?).

Gentoo uses gnat-community / gnat-gpl from AdaCore, but I don't think their bindist useable for our purposes, really: It requires running some kind of installer that depends on a bunch of libraries, including X11 and dbus – so this would be a painful bootstrapping chain.

I wonder if you may have any insight?

@ghost
Copy link
Copy Markdown
Author

ghost commented May 24, 2022

Ok.

@ghost ghost closed this May 24, 2022
@ghost ghost deleted the pr/zhf/gnat-propagate-brokenness branch January 23, 2024 06:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant