nixos: move matrix services into their category#172819
nixos: move matrix services into their category#172819piegamesde merged 1 commit intoNixOS:masterfrom
Conversation
|
How would removing the matrix- prefix additionally break things? If somebody relies on the module path, this is already a breaking change. |
|
It would be a breaking change if the option name is to be shortened,
which should be desired since e.g. services.matrix-synapse is redundant
as there is only one synapse service; the same for conduit.
|
|
No. Those names should not be touched, and are not redundant. Conduit for example explicitly requested to be packaged as matrix-conduit, and the module name should match the pname if possible. What is redundant though is the new module file path: |
|
You could do something like |
|
Based on the experience with |
That sounds good, I've updated the patch. |
|
Gentle ping! |
|
Gentle ping! |
Description of changes
This better organize Matrix-related services. IMHO the matrix- prefix should be drop from the names, but I'm not sure if the backward incompatibility is worth it.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes