psensor: add -Wno-error due to increasing compiler strictness#172177
Conversation
This Hydra failure: https://hydra.nixos.org/log/iq8zqmw7yclgwpvr8i8clwf2sh67jb0i-psensor-1.2.1.drv ...appears to be the result of the package shipping with -Werror and gcc accreting ever-increasing quantities of warnings as time progresses. Let's not treat the compiler warnings as errors.
Author
|
The ZHF announcement PR says: "Please ping @NixOS/nixos-release-managers on the PR and add the 0.kind: build failure label to the pull request. If you're unable to because you're not a member of the NixOS org please ping @dasJ, @tomberek, @jonringer, @Mic92" I am unable to add this build label, so I therefore am issuing this ping. |
Member
|
Result of 1 package built:
|
davidak
approved these changes
May 9, 2022
Member
davidak
left a comment
There was a problem hiding this comment.
Change looks good
Builds, works
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZHF: #172160
Description of changes
This Hydra failure:
https://hydra.nixos.org/log/iq8zqmw7yclgwpvr8i8clwf2sh67jb0i-psensor-1.2.1.drv
...appears to be the result of the package shipping with -Werror and
gcc accreting ever-increasing quantities of warnings as time
progresses. Let's not treat the compiler warnings as errors.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes