The ZHF announcement PR says: "Please ping @NixOS/nixos-release-managers on the PR and add the 0.kind: build failure label to the pull request. If you're unable to because you're not a member of the NixOS org please ping @dasJ, @tomberek, @jonringer, @Mic92"

I am unable to add this build label, so I therefore am issuing this ping.

Please squash the commits.

I squashed them in the github UI.

We usually create merge commits which are missing with this, that's why i haven't used it.

We usually create merge commits which are missing with this, that's why i haven't used it.

I massively prefer squashing, it keeps the history readable and cherry-pickable (you can't git cherry-pick a merge commit).

Git merges were never meant to be used the way the github web UI uses them -- for applying patchsets. Git merges were always meant for long-lived branches that get merged more than once, like our staging and staging-next.

Github pushes excessive use of merge commits because they don't like the fact that rebasing/cherrypicking a commit changes its hash. This costs them more storage (less deduplication), but the real problem is that it breaks all their big data analytics.

I agree, but this is not the place to change the rules.

I agree, but this is not the place to change the rules.

Oh, I didn't know there was a formal policy about this. I've seen people merge my PRs using both styles.

In any event, I should try to remember to squash commits myself.

It's even worse. There is an informal policy.
We should document a sane policy, so it's done consistently.
But not in this issue...