Skip to content

pcb2gcode: enableParallelBuilding = true#172171

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

pcb2gcode: enableParallelBuilding = true#172171
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 9, 2022

Description of changes

Enable parallel building for pcb2gcode.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Kritnich May 9, 2022 11:47
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 9, 2022
@Artturin
Copy link
Copy Markdown
Member

Artturin commented May 13, 2022

@ofborg build pcb2gcode

@Artturin
Copy link
Copy Markdown
Member

Artturin commented May 14, 2022

build failure on linux

@ghost
Copy link
Copy Markdown
Author

ghost commented May 15, 2022

build failure on linux

really?

I see "All checks have passed 5 skipped, 22 successful, and 1 neutral checks".

Does the github web UI show you something different?

@ghost ghost closed this Jun 19, 2022
@Artturin
Copy link
Copy Markdown
Member

Artturin commented Jun 19, 2022

build failure on linux

really?

I see "All checks have passed 5 skipped, 22 successful, and 1 neutral checks".

Does the github web UI show you something different?

The neutral is the one that failed

https://github.com/NixOS/nixpkgs/pull/172171/checks?check_run_id=6351245691

The build succeeded one time and not the other so the build is not parallel friendly

@ghost ghost deleted the pr/pcb2gcode-parallel branch January 23, 2024 06:49
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kritnich Kritnich Awaiting requested review from Kritnich

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Artturin