Skip to content

db-4.8.nix: add -Wno-format-security if hostPlatform.isStatic#170753

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

db-4.8.nix: add -Wno-format-security if hostPlatform.isStatic#170753
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 28, 2022

Description of changes

Without this commit, pkgsStatic.db48 fails to build with:

../dist/../crypto/aes_method.c: In function '__aes_err':
../dist/../crypto/aes_method.c:270:2: error: format not a string literal and no format arguments [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat-security-Werror=format-security8;;]
270 | __db_errx(env, errstr);
| ^~~~~~~~~

Things done
  • Built on platform(s)
    • powerpc64le-linux
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Without this commit, pkgsStatic.db48 fails to build with:

  ../dist/../crypto/aes_method.c: In function '__aes_err':
  ../dist/../crypto/aes_method.c:270:2: error: format not a string literal and no format arguments [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat-security-Werror=format-security8;;]
     270 |  __db_errx(env, errstr);
         |  ^~~~~~~~~
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 28, 2022

Sorry, this was due to a mistake of mine.

@ghost ghost closed this Apr 28, 2022
@ghost ghost deleted the db48-disable-format-security-static-builds branch April 28, 2022 09:49
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 28, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants