dante: remove hardwired PATH= from redefgen.sh script#170707
Conversation
Let's remove the hardwired PATH= setting from the redefgen.sh script which is executed when autoreconfHook is enabled. This resolves the following failure: build flags: SHELL=/nix/store/i2k8pqqzrmaafz2lf1dly1w96n4xpf2w-bash-5.1-p16/bin/bash Making all in include make[1]: Entering directory '/build/dante-1.4.3/include' make all-am make[2]: Entering directory '/build/dante-1.4.3/include' sh ../include/redefgen.sh ../include ../include/redefgen.sh: line 13: egrep: command not found ../include/redefgen.sh: line 13: egrep: command not found ../include/redefgen.sh: line 13: awk: command not found
Shados
approved these changes
Apr 28, 2022
Member
|
Result of 2 packages built:
|
davidak
approved these changes
May 9, 2022
Member
davidak
left a comment
There was a problem hiding this comment.
Change looks good
No build error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Let's remove the hardwired PATH= setting from the redefgen.sh script
which is executed when autoreconfHook is enabled. This resolves the
following failure:
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)