Skip to content

webrtc-audio-processing: enable powerpc64le#170191

Merged
Mindavi merged 1 commit intostagingfrom
unknown repository
Apr 25, 2022
Merged

webrtc-audio-processing: enable powerpc64le#170191
Mindavi merged 1 commit intostagingfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 25, 2022

Description of changes

This commit enables powerpc64le for webrtc-audio-processing, following
the pattern established by riscv64 support in f13cf5e.

It is unfortunate that upstream doesn't use tooling that can figure
out endianness by querying the compiler (e.g. autoconf, cmake, meson,
etc all know how to do this).

Things done
  • Built on platform(s)
    • x86_64-linux
    • powerpc64le-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bobby285271
Copy link
Copy Markdown
Member

bobby285271 commented Apr 25, 2022

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 25, 2022
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 25, 2022

Bummer that this causes so much rebuild.

If you prefer I can make the patch conditional on the hostPlatform and submit a patch to staging that removes the conditional. Or I could just send the patch to staging (when it reopens). This is not even remotely release-critical.

Mindavi
Mindavi approved these changes Apr 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mindavi Mindavi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one question, LGTM

Edit: yeah, send to staging.

Also would be nice if this could be upstreamed ❤️

@ghost ghost marked this pull request as draft April 25, 2022 05:49
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 25, 2022

Okay, let's see if I remember how to change the base branch without mass-inviting every single nixpkgs reviewer.... ::crosses fingers::

@ghost ghost changed the base branch from master to staging April 25, 2022 05:59
webrtc-audio-processing: enable powerpc64le
dbf7109 
This commit enables powerpc64le for webrtc-audio-processing, following
the pattern established by riscv64 support in f13cf5e.
@ghost ghost marked this pull request as ready for review April 25, 2022 05:59
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 25, 2022

I originally wrote this patch a few days ago, and earlier today I found out that Gentoo hard written a much more complete version of it as part of their qtwebengine support.

I've updated this PR to include the Gentoo version, and credited them at the top of the patch.

@ghost ghost requested a review from Mindavi April 25, 2022 06:00
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 25, 2022

Thanks. Staging is closed until 2022-May-15 so I will mark this as draft until then to keep it off of the maintainers' to-do list.

@ghost ghost marked this pull request as draft April 25, 2022 06:04
@Mindavi
Copy link
Copy Markdown
Contributor

Mindavi commented Apr 25, 2022

Btw, contributing now contains a guide describing the rebase process for retargeting 👍

@Mindavi
Copy link
Copy Markdown
Contributor

Mindavi commented Apr 25, 2022 •
edited
Loading

Staging is not closed, see #165792. Also, this looks quite safe to me.

@ghost ghost marked this pull request as ready for review April 25, 2022 06:32
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 25, 2022 •
edited by ghost
Loading

Staging is not closed, see #165792. Also, this looks quite safe to me.

You're right. Sorry about that. The other staging PRs I have affect stdenv, so I had been thinking of the earlier 17-Apr deadline.

@Mindavi
Copy link
Copy Markdown
Contributor

Mindavi commented Apr 25, 2022

No worries :). Cross-compiled for aarch64-multiplatform as well, let's get this in.

@Mindavi Mindavi merged commit d4f2a8e into NixOS:staging Apr 25, 2022
@ghost ghost deleted the webrtc-enable-powerpc branch April 25, 2022 06:50
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobby285271 @Mindavi