Skip to content

gstreamer: add bluezSupport flag#170188

Merged
SuperSandro2000 merged 1 commit intostagingfrom
unknown repository
Jun 5, 2022
Merged

gstreamer: add bluezSupport flag#170188
SuperSandro2000 merged 1 commit intostagingfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 25, 2022

Description of changes

This allows the option of compiling gstreamer (and packages depending upon it) without bluetooth support.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from matthewbauer April 25, 2022 03:47
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 25, 2022
Mindavi
Mindavi approved these changes Jun 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mindavi Mindavi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. To staging?

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 3, 2022
SuperSandro2000
SuperSandro2000 approved these changes Jun 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please change to staging

@ghost ghost marked this pull request as draft June 5, 2022 06:50
@ghost ghost changed the base branch from master to staging June 5, 2022 06:52
@ghost ghost marked this pull request as ready for review June 5, 2022 06:54
@ghost
Copy link
Copy Markdown
Author

ghost commented Jun 5, 2022

Rebased to staging.

gstreamer: add bluezSupport flag
421ca6d 
This allows the option of compiling gstreamer (and packages depending
upon it) without bluetooth support.
@bobby285271 bobby285271 removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 5, 2022
@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Jun 5, 2022

@ofborg build gst_all_1.gst-plugins-bad

@SuperSandro2000 SuperSandro2000 merged commit 99cd957 into NixOS:staging Jun 5, 2022
@ghost ghost deleted the gstreamer-bluezSupport branch June 6, 2022 07:05
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperSandro2000 @Mindavi @bobby285271