jesec-rtorrent: 0.9.8-r15 -> 0.9.8-r16#169236
Conversation
275e630 to
8ce3acc
Compare
|
@AndersonTorres I do wish there was some way we could clean up the usage of |
There was a problem hiding this comment.
There is no reason to split this line.
The reason for this is obvious: the first is a Boolean argument that controls the insertion of the second one as a dependency.
There was a problem hiding this comment.
I agree, except for the fact that this was the result of running the file through nixpkgs-fmt -- no formatter will be able to know this (and if Nixpkgs is auto-formatted in the future, this will happen anyways).
There was a problem hiding this comment.
This was the only thing the formatter found? Six lines in a diff that worsens the legibility of a code?
And people ask why I don't like them...
Also formatters are not to be the last word. Machines are meant to help us, not us to help them.
There was a problem hiding this comment.
This was the only thing the formatter found? Six lines in a diff that worsens the legibility of a code?
And people ask why I don't like them...
Also formatters are not to be the last word. Machines are meant to help us, not us to help them.
The relevant snippet is jesec-rtorrent = recurseIntoAttrs
(callPackage ../tools/networking/p2p/jesec-rtorrent {
callPackage = newScope pkgs.jesec-rtorrent;
});
rtorrent-jesec = jesec-rtorrent.rtorrent;
libtorrent-jesec = jesec-rtorrent.libtorrent;If we just flip rtorrent-jesec with jesec-rtorrent, it should work fine. rtorrent-jesec = recurseIntoAttrs
(callPackage ../tools/networking/p2p/jesec-rtorrent {
callPackage = newScope pkgs.rtorrent-jesec;
});
jesec-rtorrent = rtorrent-jesec.rtorrent;
jesec-libtorrent = rtorrent-jesec.libtorrent; |
|
I still think this is confusing considering the set name and the exposed package names at top level are so similar. I don't think there's any better solution, though... |
|
@AndersonTorres Maybe we should consider reverting the addition of the package set/scope for the rtorrent and libtorrent variations? |
|
No problems to me. However, do not to put libtorrent inside |
8ce3acc to
5fe5016
Compare
5fe5016 to
73ff43b
Compare
|
@ofborg eval |
2715bc0 to
0892af9
Compare
0892af9 to
b9e02e7
Compare
|
@AndersonTorres Should be good now -- OfBorg passes. I did add an extra commit though, please see that before merging. |
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes