meson: apply patch fixing exception during cross-compilation#168753
Merged
jtojnar merged 1 commit intoNixOS:stagingfrom Apr 21, 2022
Merged
meson: apply patch fixing exception during cross-compilation#168753jtojnar merged 1 commit intoNixOS:stagingfrom
jtojnar merged 1 commit intoNixOS:stagingfrom
Conversation
NickCao
approved these changes
Apr 16, 2022
Member
NickCao
left a comment
There was a problem hiding this comment.
168 newly succeeding and zero regression on my hydra.
jtojnar
reviewed
Apr 16, 2022
Contributor
|
|
Fixes a traceback where you get the following error: - AttributeError: 'NoneType' object has no attribute 'get_command' This happened when cross-compiling e.g. harfbuzz.
d57723f to
e91229b
Compare
FRidh
approved these changes
Apr 19, 2022
AndersonTorres
approved these changes
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a traceback where you get the following error:
This happened when cross-compiling e.g. harfbuzz.
I did release this on my hydra and didn't see any new regressions with it, so I'm pretty certain it will only improve meson and not cause further issues.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes