chromium{Beta,Dev}: Fix a build error by disabling PGO#168555
Merged
primeos merged 1 commit intoNixOS:masterfrom Apr 14, 2022
Merged
chromium{Beta,Dev}: Fix a build error by disabling PGO#168555primeos merged 1 commit intoNixOS:masterfrom
primeos merged 1 commit intoNixOS:masterfrom
Conversation
This fixes build errors like this: error: Could not read profile ../../chrome/build/pgo_profiles/chrome-linux-4951-1649181099-528ef6669805f2d3db6f3ad7429cfa57a6078271.profdata: unsupported instrumentation profile format version We already package the most recent stable LLVM version for Chromium but Google relies on unreleased (Git) versions (thanks...). This isn't ideal but I don't have the time to package yet another LLVM version so it'll have to cut it for now. See build/config/compiler/pgo/pgo.gni: - 0 : Means that PGO is turned off. - 1 : Used during the PGI (instrumentation) phase. - 2 : Used during the PGO (optimization) phase. With is_official_build the default is chrome_pgo_phase = 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes build errors like this:
error: Could not read profile ../../chrome/build/pgo_profiles/chrome-linux-4951-1649181099-528ef6669805f2d3db6f3ad7429cfa57a6078271.profdata: unsupported instrumentation profile format version
We already package the most recent stable LLVM version for Chromium but Google
relies on unreleased (Git) versions (thanks...). This isn't ideal but I
don't have the time to package yet another LLVM version so it'll have to
cut it for now.
See build/config/compiler/pgo/pgo.gni:
With is_official_build the default is chrome_pgo_phase = 2.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes