Skip to content

python-modules/sip: do not generate manylinux wheels on powerpc64le#168115

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

python-modules/sip: do not generate manylinux wheels on powerpc64le#168115
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 10, 2022 •
edited by ghost
Loading

Description of changes

This is an alternative fix suggested by @tpwrules here for #168083. Instead of changing the pythonHostPlatform used when building python, we instead refuse to generate manylinux-family wheels.

This commit allows PyQt5 to build on powerpc64le.

Closes 168083.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
    • powerpc64le-linux
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 10, 2022
@ghost ghost mentioned this pull request Apr 10, 2022
Merged
8 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 10, 2022
python-modules/sip: do not generate manylinux wheels on powerpc64le
33e975b 
This is an alternative fix suggested by @tpwrules for #168083.
Instead of changing the `pythonHostPlatform` used when building
python, we instead refuse to generate `manylinux`-family wheels.

This commit allows PyQt5 to build on powerpc64le.
@ghost ghost marked this pull request as ready for review April 10, 2022 11:16
@ghost ghost requested review from FRidh and jonringer as code owners April 10, 2022 11:16
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 11, 2022

Marking as draft per @tpwrules indication that #168083 is a better solution.

@ghost ghost marked this pull request as draft April 11, 2022 02:11
@ghost
Copy link
Copy Markdown
Author

ghost commented Jun 19, 2022

Closed by #168083

@ghost ghost closed this Jun 19, 2022
@ghost ghost deleted the fix-ppc-powerpc-tpwrules branch January 23, 2024 06:45
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants