Skip to content

openjdk: add support for powerpc64le#168110

Merged
SuperSandro2000 merged 1 commit intomasterfrom
unknown repository
Apr 12, 2022
Merged

openjdk: add support for powerpc64le#168110
SuperSandro2000 merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 10, 2022

Description of changes

This commit adds entries to the Rosetta Stones in adoptopenjdk-bin/generate-sources.py and compilers/openjdk/8.nix, and runs adoptopenjdk-bin/generate-sources.py to regenerate adoptopenjdk-bin/sources.json.

With this commit, nix-build . -A jdk8_headless succeeds on powerpc64le. Headless jdk is used as part of the build process for many packages so this opens up access to them.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
    • powerpc64le-linux
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ghost ghost marked this pull request as ready for review April 10, 2022 09:47
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reference to this? I could only find powerpc64le.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@SuperSandro2000
Copy link
Copy Markdown
Member

@ofborg eval

@ofborg ofborg bot requested a review from edwtjo April 11, 2022 21:59
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 11, 2022
This commit adds entries to the Rosetta Stones in
adoptopenjdk-bin/generate-sources.py and compilers/openjdk/8.nix, and
runs adoptopenjdk-bin/generate-sources.py to regenerate
adoptopenjdk-bin/sources.json.

With this commit, `nix-build . -A jdk8_headless` succeeds on
powerpc64le.  Headless jdk is used as part of the build process for
many packages so this opens up access to them.
@SuperSandro2000 SuperSandro2000 merged commit 3a537be into NixOS:master Apr 12, 2022
@ghost ghost deleted the openjdk-powerpc branch April 12, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant