Skip to content

nodejs: mark versions older than 14 as vulnerable#167110

Merged
ajs124 merged 1 commit into
NixOS:masterfrom
mweinelt:nodejs-12-eol
May 4, 2022
Merged

nodejs: mark versions older than 14 as vulnerable#167110
ajs124 merged 1 commit into
NixOS:masterfrom
mweinelt:nodejs-12-eol

Conversation

@mweinelt

@mweinelt mweinelt commented Apr 4, 2022

Copy link
Copy Markdown
Member

NodeJS 12 will reach EOL on 2022/04/30.

Description of changes

Closes: #166440

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

NodeJS 12 will reach EOL on 2022/04/30.
@mweinelt

mweinelt commented Apr 4, 2022

Copy link
Copy Markdown
Member Author

Please migrate to nodejs-14_x or newer.

@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 4, 2022
@K900

K900 commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

n8n should be on 14 already on unstable?

@iblech

iblech commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

For whitebophir, this is done by the older pull request #158000 which needs merging.

@ajs124

ajs124 commented May 3, 2022

Copy link
Copy Markdown
Member

2022/04/30 has passed, so should we just go ahead with this?

@ajs124 ajs124 merged commit 1333a38 into NixOS:master May 4, 2022
@mweinelt mweinelt deleted the nodejs-12-eol branch May 4, 2022 09:20
@ajs124 ajs124 mentioned this pull request Jul 4, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

Development

Successfully merging this pull request may close these issues.

NodeJS 12 EOL

5 participants