firefox: fix drmSupport flag#166078
Merged
lovesegfault merged 1 commit intoNixOS:masterfrom Mar 28, 2022
Merged
Conversation
doronbehar
reviewed
Mar 28, 2022
In NixOS#109133 @alyssais discovered that the drmSupport flag stopped working. This is because Mozilla decided around Firefox 51 (mozbz#1289634) to swap the default values and our flag was asking for the wrong thing all along. Since this flag has now been enabled for multiple years, disabling it would mean a regression for our users. Leaving it enabled should be unproblematic since it only controls whether Firefox shows the EME nagbar, that allows to enable Widevine CDM, when a site requests it. The choice is therefore completely up to the enduser. Disabling this nagbar is still possible at runtime by setting `browser.eme.ui.enabled` to `false`. If Widevine CDM was inadvertently enabled it can be disabled at `media.gmp-widevinecdm.enabled`. Supersedes: NixOS#109133
doronbehar
approved these changes
Mar 28, 2022
10 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #109133 @alyssais discovered that the drmSupport flag stopped
working. This is because Mozilla decided around Firefox 51
(mozbz#1289634) to swap the default values and our flag was asking for
the wrong thing all along.
Since this flag has now been enabled for multiple years, disabling it
would mean a regression for our users. Leaving it enabled should be
unproblematic since it only controls whether Firefox shows the EME nagbar,
that allows to enable Widevine CDM, when a site requests it. The choice is
therefore completely up to the enduser.
Disabling this nagbar is still possible at runtime by setting
browser.eme.ui.enabledtofalse. If Widevine CDM was inadvertentlyenabled it can be disabled at
media.gmp-widevinecdm.enabled.Supersedes: #109133
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes